[_]: fix/add http codes to should retry and add retry after #45
+231
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzunigax2
commented
Feb 10, 2026
jzunigax2
commented
- Updated the Temporary method to include additional status codes (408, 429) for temporary errors.
- Added RetryAfter method to calculate wait time based on rate limit headers in the response.
- Updated the Temporary method to include additional status codes (408, 429) for temporary errors. - Added RetryAfter method to calculate wait time based on rate limit headers in the response.
- Introduced comprehensive tests for the RetryAfter method in the HTTPError struct, covering various scenarios including valid seconds, HTTP date formats, absence of headers, and invalid values. - Added tests to ensure correct behavior for temporary errors (HTTP status codes 408 and 429) in the GetUsage and GetLimit functions, verifying that they return the expected HTTPError instances.
larryrider
approved these changes
Feb 13, 2026
jzunigax2
deleted the
fix/add-http-codes-to-should-retry-and-add-retry-after
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.